This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, C++] Make Canonical ICE instead of just warn when mismatching
Gabriel Dos Reis wrote:
> Andrew_Pinski@PlayStation.Sony.Com writes:
>
> | Since Doug mentioned it would ICE without checking enabled
> | (http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00172.html), it seems the
> | right thing to just ICE and then watch out for more fall out. Yes right
> | now we know of a testcase where before this patch we will pass but after
> | we will now ICE but it seems like a good idea to get this ICEing before we
> | get more testcases where we ICE with checking disable. (I posted the
> | reduced testcase for this problem at
> | http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00209.html ).
> |
> | OK? Bootstrapped and tested on i686-linux-gnu with no regressions.
I think we should leave this as is for now, and turn it into a sorry()
or internal_error() before the 4.3 release. For now, it's nice to be
able to work around any failures. You can file a P1 bug against 4.3 to
make that change, if you like.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713