This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/3] libgcc: Remove local _Unwind_Word and _Unwind_Sword uses
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, iant at google dot com
- Date: Mon, 22 Jan 2007 19:38:30 -0800
- Subject: Re: [PATCH 1/3] libgcc: Remove local _Unwind_Word and _Unwind_Sword uses
- References: <20070122132632.GA8002@blc4eb430604175.ibm.com>
Andreas Krebbel wrote:
> 2007-01-22 Andreas Krebbel <krebbel1@de.ibm.com>
>
> * unwind-dw2-fde.c (get_cie_encoding): Replaced _Unwind_Word with
> _uleb128_t and _Unwind_SWord with _sleb128_t.
> * unwind-dw2.c (extract_cie_info, execute_stack_op, execute_cfa_program,
> uw_frame_state_for, uw_update_context_1): Likewise.
> * unwind-c.c (parse_lsda_header, PERSONALITY_FUNCTION): Likewise.
> * unwind-pe.h (read_uleb128, read_sleb128,
> read_encoded_value_with_base): Likewise.
> * unwind-generic.h: Define _sleb128_t and _uleb128_t types.
I think that renaming the _Unwind_Word types is confusing for the reason
that you say; the leb128 type names suggest some kind of big-num type.
But, the patch is OK without the name-change after the macro patch goes in.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713