This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH objc/ RFH testsuite] Fix objc PCH (PR 30479)
On Thu, Jan 18, 2007 at 12:33:49PM -0800, Mike Stump wrote:
> Sorry for taking so long on this, I wanted to do some research on this
> first...
>
> On Jan 16, 2007, at 9:12 PM, Andrew Pinski wrote:
> > The problem here is that we were hashing on pointers which broke
> >when
> >we loaded in the PCH and the identifiers moved. This fixes the
> >problem
> >by using the hash of the identifier which already exists.
>
> Ok for mainline, 4.2 and 4.1 as appropriate and thanks for fixing this.
>
> >I also need some help with the testsuite
>
> I'm happy to Ok the patch that you have. I think it is better than
> what we have now. I didn't see anything that would hurt cross
> testing. Even if it had no hope of working, we could disable with
> $target != $ build until it could be fixed. I'd rather have this
> fixed, then not put in the patch.
>
> Does that sound reasonable?
It sounds reasonable to me.
Janis