This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 4.1/4.2 PATCH: PR middle-end/20218: Can't use __attribute__ ((visibility ("hidden"))) to hide a symbol

On Mon, Jan 15, 2007 at 01:19:40AM +0000, Richard Sandiford wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> > I am enclosing backported 4.1/4.2 patches for PR middle-end/20218.
> 
> If you're backporting a patch for elfos.h to a release branch, I think
> you need to explain why you think it's safe for all elfos ports.
> I realise you can't test them all, but you can at least (for example)
> grep for definitions of ASM_OUTPUT_EXTERNAL.
> 
> Your original mainline patch broke bootstrap on mips-linux-gnu (which
> I know you know, because you commented on it).  I think it would be
> reasonable under the circumstances to expect you to include that fix
> in your backport too.  From a quick grep, I'm also dubious about pa/elf.h.
> Does anything undefine your new elfos definition before pa/elf.h defines
> the new one?  What about config/score/score.h?

I don't like to blindly undef ASM_OUTPUT_EXTERNAL to make an ELF
backend to compile. It doesn't belong to my bug fix. I can provide
a separate patch to undef ASM_OUTPUT_EXTERNAL for those ports which
are affected.  I only got one report on MIPS.

Ideally, ASM_OUTPUT_EXTERNAL defined in each ELF backend should be
double checked to see if it should be rewritten.  Otherwise, that ELF
backend may not include my bug fix, which is the case for MIPS in
mainline. If someone wants to fix it, I can help.


H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]