This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 4.1/4.2 PATCH: PR middle-end/20218: Can't use __attribute__ ((visibility ("hidden"))) to hide a symbol
- From: Richard Sandiford <richard at codesourcery dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 15 Jan 2007 01:19:40 +0000
- Subject: Re: 4.1/4.2 PATCH: PR middle-end/20218: Can't use __attribute__ ((visibility ("hidden"))) to hide a symbol
- References: <20070109151015.GB22076@lucon.org>
"H. J. Lu" <hjl@lucon.org> writes:
> I am enclosing backported 4.1/4.2 patches for PR middle-end/20218.
If you're backporting a patch for elfos.h to a release branch, I think
you need to explain why you think it's safe for all elfos ports.
I realise you can't test them all, but you can at least (for example)
grep for definitions of ASM_OUTPUT_EXTERNAL.
Your original mainline patch broke bootstrap on mips-linux-gnu (which
I know you know, because you commented on it). I think it would be
reasonable under the circumstances to expect you to include that fix
in your backport too. From a quick grep, I'm also dubious about pa/elf.h.
Does anything undefine your new elfos definition before pa/elf.h defines
the new one? What about config/score/score.h?
Richard