This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC,PATCH] Builtin macros for sizes of standard types


On Wed, 10 Jan 2007, Andreas Krebbel wrote:

> I've checked that the macros are defined properly and that the 
> documentation builds fine.
> 
> OK for mainline?

I'll defer to a preprocessor maintainer on the principle of having these 
macros, but note:

* You need testcases (of the form

int x[sizeof(int) == __SIZEOF_INT__ ? 1 : -1];

for example) for all the new macros.

* You should have and use builtin_define_type_sizeof like 
builtin_define_type_precision.

> + Defined to the number of bytes of the c standard data types: @code{int},

"C" not "c".

> + @code{long}, @code{long long}, @code{short} and @code{void*}.

"void *" not "void*".

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]