This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Wmissing-base-class-initializer (PR7651 Define -Wextra strictly in terms of other warning flags)
On 10 Jan 2007 03:24:24 +0100, Gabriel Dos Reis
<gdr@integrable-solutions.net> wrote:
"Manuel LÃpez-IbÃÃez" <lopezibanez@gmail.com> writes:
[...]
| > -Wextra should be split into *logical* subsets. I fully appreciate
| > the task is hard, but if we review only one option at a time, we may
| > very well miss the picture and end up leaking implementation detail
| > information.
|
| I completely agree. I am trying to do this, so if you could point to
| logical subsets, I will happily fix the patches. Still, I think it
| would be easier to see the relations once Wextra is completely cleaned
| up.
so, once we have checked in zillions of option names, we would
have seen the design; that is where I'm trying not to get at. I would
like to see a general idea of the design first. Once,
something is in, it tends to be difficult to get it out.
OK. So what about I prepare all the patches the would be neccessary to
clean up Wextra (I think they will be around 10) but don't commit any
of them until all of them are in the queue. Then I can write a mail to
gcc-patches listing all of them and a short summary.
This will enable people to look at each patch separately but also see
any connection between them that I missed. When all the patches are
reviewed and accepted, I can commit each of them one at a time.
Is this a good plan for you?
| There is still a lot of time before GCC 4.3 is released
I have been there before :-)
Yes, it was a stupid thing to say...newbie mistake ;-)
| > One way to do that is that we have a summary of the kind
| > of messages currently controlled by -Wextra.
|
| I don't get this.
grep warn_extra; make a "digest".
It is actually extra_warnings, warn_extra doesn't exist. I would
prefer the plan I proposed above because it seems to me that "digest"
will get ignored but actual patches can be commented and discussed.
Anyway, if you think that the digest is better, I will do it that way.