Re: PATCH RFC: Use parentheses in dumps for same-priority operands

["Richard Guenther" <richard dot guenther at gmail dot com>]

On 09 Jan 2007 20:35:33 -0800, Ian Lance Taylor <iant@google.com> wrote:
> While looking at some floating point code recently, I was surprised to
> see that the dump files do not report how operators of the same
> precedence associate.  This of course matters for floating point.  The
> compiler represents it correctly, it is just not printed in the dump
> files.
>
> For example, for this test case:
>
> double foo (double a, double b, double c) { return (a - (b - c)); }
>
> The final_cleanup dump file includes this:
>
> foo (a, b, c)
> {
> <bb 2>:
>   return a - b - c;
>
> }
>
> With this trivial patch, the dump file looks like this:
>
> foo (a, b, c)
> {
> <bb 2>:
>   return a - (b - c);
>
> }
>
> This correctly represents the order of operations.

I think this is a good enhancement.  Does it avoid printing the
parens if the evaluation order is left-to-right?

Thanks,
Richard.

> I've tested this patch with a bootstrap and testsuite run on
> i686-pc-linux-gnu.  I plan to commit it in a day or two unless
> somebody objects.
>
> Ian
>
>
> 2007-01-09  Ian Lance Taylor  <iant@google.com>
>
>         * tree-pretty-print.c (dump_generic_node): Print parentheses when
>         operands have the same priority.