This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] gcc/testsuite/gcc.c-torture/compile/pr27528.c

From: Mike Stump <mrs at apple dot com>
To: Hui-May Chang <hm dot chang at apple dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 8 Jan 2007 12:23:53 -0800
Subject: Re: [patch] gcc/testsuite/gcc.c-torture/compile/pr27528.c
References: <EFFB55B7-CB52-45C3-ABF0-99F456569A28@apple.com>

On Jan 6, 2007, at 1:56 PM, Hui-May Chang wrote:

We, at Apple, found pr27528.c failed on x86 MacOS as asm_operand_ok routine performs the following test,

case 'i': if (CONSTANT_P (op) && (! flag_pic || LEGITIMATE_PIC_OPERAND_P (op))) result = 1; break;

We felt asm's aren't expected to figure out the necessary sequence for pic code and would like to propose adding -fno-pic option for the test.

The following patch has been tested on ppc and x86 MacOS.
gcc/testsuite/ChangeLog:
        * gcc.c-torture/compile/pr27528.c: Add -fno-pic option.

OK?

Unless someone knows of a reason why that would be a bad change, I'm thinking of approving this patch later this week. I think this version is better than a .x file a la testsuite/gcc.c-torture/execute/ 960312-1.x because it covers all targets that might want to default to pic codegen. I'd really like to see others chime in on this one. Ian? Jan?

Follow-Ups:
- Re: [patch] gcc/testsuite/gcc.c-torture/compile/pr27528.c
  - From: Andrew Pinski
- Re: [patch] gcc/testsuite/gcc.c-torture/compile/pr27528.c
  - From: Ian Lance Taylor

References:
- [patch] gcc/testsuite/gcc.c-torture/compile/pr27528.c
  - From: Hui-May Chang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]