This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, C++] Make Canonical ICE instead of just warn when mismatching


On Thu, Jan 04, 2007 at 03:42:36PM -0800, Andrew_Pinski@PlayStation.Sony.Com wrote:
> It would be a feature if the user could fix their code if it was broken
> but their code is not the issue here but GCC is broken.  So users get a
> warning which is bogus to them and not helpful at all.  What they will do
> is just move to an older version of GCC and give up on the newer ones. 

I can only conclude that you did not read or think about anything
that Mike wrote.  Please try again.

> The real question is why was this a warning with junk after it in the 
> first place,
> it seems wrong to be a warning which the user is not able to resolve at 
> all.

So why not fix that instead?  Format the extra info into string buffers
and use %s.

> I am thinking about applying this patch as obvious and then letting people 
> file more bugs
> about problems internally to GCC.

Do not do that.

A patch which draws immediate disagreement is _NEVER_ obvious, no
matter how thoroughly you ignore the response.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]