This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Libgcc: Add documentation targets to makefile.


Brooks Moses wrote:
Daniel Jacobowitz wrote:
On Thu, Jan 04, 2007 at 03:09:02PM -0800, Brooks Moses wrote:
Currently, all of the documentation targets -- "make info", "make pdf", "make html", and "make dvi" -- are broken because the appropriate targets do not exist in the new libgcc makefile. The attached patch fixes this.

Tested, with all of the above "make" checks, on i686-pc-linux-gnu. Ok for trunk?
Don't they need .PHONY?

Not so far as I know, but I'm not really sure what .PHONY is supposed to do. In any case, they do test fine without it.

Daniel was kind enough to point me to the "make" documentation that explains why they ought to have .PHONY (which I should have looked up before), and so I've committed the attached followup patch to trunk as also obvious.


Also, the ChangeLog entries for the two patches; I forgot to post the first one, so here are both of them:

------------------------------------------------------------------
2007-01-04  Brooks Moses  <brooks.moses@codesourcery.com>

* Makefile.in: Added .PHONY entry for documentation targets.

2007-01-04 Brooks Moses <brooks.moses@codesourcery.com>

* Makefile.in: Add empty info, html, dvi, pdf targets.

------------------------------------------------------------------

- Brooks
Index: Makefile.in
===================================================================
--- Makefile.in (revision 120455)
+++ Makefile.in (working copy)
@@ -730,6 +730,8 @@
 all: $(extra-parts)

 # Documentation targets (empty).
+.PHONY: info html dvi pdf
+
 info:

 html:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]