Re: [patches,fortran] Add POINTER INTENT(*) support (PR29624)

[Tobias Burnus <burnus at net-b dot de>]

Hi,

Paul Thomas wrote:
> OK with a couple of questions/niggles....

>>> +      return gfc_notify_std (standard, "%s: %s attribute with %s
>>> attribute "
>>> +                             "at %L",
>>> +                             (standard == GFC_STD_F2003)
>>> +                               ? "Fortran 2003" : "Not in the
>>> selected standard",
>>> +                             a1, a2, where); 
> Is the language support OK with this? I seem to recall that we had
> some problems with computed messages.

I don't know. As (standard == GFC_STD_F2003) is currently always true
and the translation of "Fortran 2003" does not depend on the context, it
should be ok, except that the translator does not know what the first
"%s:" means.
Due to the colon, it should be also ok for "Not in the selected
standard", which makes it effectively two sentences.

But I'm not a specialist for l18n/i10n.
(Really problematic are strings like
  "There are %s items missing", (x?"one" : "two")
as the translation of "one" is context dependent, e.g. French
"un"/"une", German "ein"/"eine"/"eins")

I'll submit it tomorrow as above, unless someone objects or has a better
suggestion.


>>> +  /* Check INTENT(IN), unless the object itself of higher up in the
>>> +     hierarchy is a pointer.  */
>>>     
> Not only is the symtax a bit odd but I think that , "unless the object
> itself is the component or sub-component of a pointer." is clearer.
(I should have re-read the comments, the syntax is odd indeed; even with
"or" it is barely decipherable.)

> Thanks!
Thanks for reviewing the patch!

Tobias