This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] Use host fragment for PPC-Darwin stage1_cflags


Daniel Jacobowitz wrote:
On Tue, Dec 19, 2006 at 12:06:00PM +0100, Paolo Bonzini wrote:
+# The spiffy cpp-precomp chokes on some legitimate constructs in GCC
+# sources; use -no-cpp-precomp to get to GNU cpp.
+# Apple's GCC has bugs in designated initializer handling, so disable
+# that too.
+STAGE1_CFLAGS += -no-cpp-precomp -DHAVE_DESIGNATED_INITIALIZERS=0

This adds a GNU make dependency for the whole target, doesn't it? Which might be fine for Darwin, but src does not require GNU make in
general.

The Autoconf manual does not mention += among the source of non-portabilities. I also checked BSD make and it has '+=' (search for VAR_APPEND) since 1993 (revision 1.1):


http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/make/parse.c?annotate=1.126

The GNU make manual says:

* The `+=' syntax to append to the value of a variable comes from
SunOS 4 `make'.  *Note Appending More Text to Variables: Appending.

If anybody knows of a host (HPUX, Tru64, IRIX) that does not have it, please tell me.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]