This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add ATTRIBUTE_PACKED to ansidecl.h


On Wed, 6 Dec 2006, Nick Clifton wrote:

> +/* Useful for structures whoes layout must much some binary specification
> +   regardless of the alignment and padding qualities of the compiler.  */
> +#ifndef ATTRIBUTE_PACKED
> +# define ATTRIBUTE_PACKED __attribute__ ((packed))
> +#endif

Please consider using "__packed__" not "packed".  All the other ATTRIBUTE
macros use underscores to avoid conflicts with user-space macros.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]