This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran,patch] F2003 USE syntax and OpenMP module


Hi FX,

+                 gfc_error ("Module nature in USE statement at %C should "
+                            "be either INTRINSIC or NON_INTRINSIC");

I would use "shall" rather than "should".



"New in Fortran 2003: modulenature in USE statement at (1)"

I would use "module nature".



The error message for
  use, intrinsic iso_fortran_env
is not helpful:

 use, intrinsic iso_fortran_env
1
Error: Unclassifiable statement at (1)


You should really output a nicer error message as NAG f95 (!), g95 and ifort
support this invalid syntax. If you don't know that it is invalid, you
assume that gfortran does not support it or has a bug. (sunf95 has a
nicer reject message: 'Unexpected syntax: "::" was expected but found "I"')
(Alternatively, accept it in gnu or legacy, if you want.)


Otherwise it looks ok. (Except for the #if 0, but I assume you will add
ISO_FORTRAN_ENV soon  ;-) 

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]