This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ICE on free form !$omp continued directive followed by OpenMP conditional line (PR fortran/29759)

From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Daniel Franke <franke dot daniel at gmail dot com>
Date: Mon, 13 Nov 2006 10:34:13 -0800
Subject: Re: [PATCH] Fix ICE on free form !$omp continued directive followed by OpenMP conditional line (PR fortran/29759)
References: <640ad44b0611100142u7fc5259ep2cb9b195f1556935@mail.gmail.com> <20061110181715.GR23312@devserv.devel.redhat.com>

On Fri, Nov 10, 2006 at 01:17:16PM -0500, Jakub Jelinek wrote:
> On Fri, Nov 10, 2006 at 10:42:46AM +0100, Daniel Franke wrote:
> > I created a more complete testcase and added it to
> > testsuite/gfortran.dg/gomp as pr29759.f90. The patch
> > was updated accordingly.
> 
> Here is my proposed fix, !$ conditional line should really be clearing
> openmp_flag, as it is not OpenMP directive line.  The caller then does
> all that's needed, i.e. doesn't treat & at the end of last directive line
> as continuation character, but as literal & and the parser issues
> diagnostics.
> 
> Ok for 4.2/4.3?
> 

OK.

-- 
Steve

References:
- [patch, fortran] pr29759
  - From: Daniel Franke
- [PATCH] Fix ICE on free form !$omp continued directive followed by OpenMP conditional line (PR fortran/29759)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]