This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Make gcc/configure* ld version parser a little bit less strict
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 10 Nov 2006 21:16:00 +0000 (UTC)
- Subject: Re: [PATCH] Make gcc/configure* ld version parser a little bit less strict
- References: <20061107130835.GS24872@devserv.devel.redhat.com>
On Tue, 7 Nov 2006, Jakub Jelinek wrote:
> Hi!
>
> GCC ld version parser doesn't grok Fedora Core 6 and later ld --version
> output (which includes also rpm %{release} number, as binutils broken
> libtool stuff resulted in choosing installed libbfd instead of the newly
> built libbfd, which sometimes aren't ABI compatible (remember libbfd
> doesn't care about binary compatibility)). As ld_date was parsed correctly,
> the only result was that on FC6 and later HAVE_COMDAT_GROUP is 0 rather than
> 1 even when the included linker supports comdat just fine.
>
> The following patch relaxes the tight version checking a little bit.
>
> Ok for 4.3/4.2/4.1?
>
> 2006-11-07 Jakub Jelinek <jakub@redhat.com>
>
> * configure.ac (ld_vers): Parse GNU ld version 2.17.50.0.3-6 20060715
> style versions.
> * configure: Rebuilt.
While I think accepting the output of more of the wide range of linker
versions out there is a good idea (but can't approve the patch), I note
that libstdc++ has its own parser of ld version numbers (simpler, and so
probably accepting fewer variants) in GLIBCXX_CHECK_LINKER_FEATURES. It
might be a good idea to have a common parser shared by both directories
(based on the version used in gcc/).
--
Joseph S. Myers
joseph@codesourcery.com