This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix type_info comparison for ARM EABI


> 2006-11-01  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* libsupc++/typeinfo (__GXX_TYPEINFO_EQUALITY_INLINE): Define.
> 	Use instead of __GXX_MERGED_TYPEINFO_NAMES to condition inline
> 	definitions.
> 	* libsupc++/tinfo.cc (operator==): Condition on
> 	__GXX_TYPEINFO_EQUALITY_INLINE; check __GXX_MERGED_TYPEINFO_NAMES
> 	to determine algorithm.
> 	* libsupc++/tinfo2.cc (type_info::before): Likewise.

This seems confused to me. It is possible that I am the one confused.

I would like to see better documentation for these new macros and what
you are trying to accomplish. Specifically, I'd like to see documentation on

__GXX_MERGED_TYPEINFO_NAMES
__GXX_TYPEINFO_EQUALITY_INLINE

and how they inter-relate, and what problem you are trying to solve.
This should be added as comments in the code.

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]