This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR6321

From: Mark Mitchell <mark at codesourcery dot com>
To: Dirk Mueller <dmuell at gmx dot net>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 30 Oct 2006 14:18:34 -0800
Subject: Re: [PATCH] PR6321
References: <200610290153.30738.dmuell@gmx.net> <200610302045.44617.dmuell@gmx.net> <454659F9.6070508@codesourcery.com> <200610302226.56191.dmuell@gmx.net>

Dirk Mueller wrote:

2006-10-30 Dirk Mueller <dmueller@suse.de>

        PR c++/6321
        * c-decl (start_function): Move code for main decl warning ..
        * c-common.c (check_main_arguments): .. here.
        * c-common.h (check_main_arguments): Declare.

* decl.c(grokfndecl): Use check_main_arguments.

This is OK, thanks.

(Pedantically, I think "check_main_parameter_types" would be better; generally "arguments" are the things you pass to a function, while "parameters" are the things that get replaced by the arguments when you run the function. But, GCC doesn't adhere to this convention in many other places, and I don't want to make you tweak your patch any more. So, you can decide whether to do that or not, as you please.)

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- [PATCH] PR6321
  - From: Dirk Mueller
- Re: [PATCH] PR6321
  - From: Dirk Mueller
- Re: [PATCH] PR6321
  - From: Mark Mitchell
- Re: [PATCH] PR6321
  - From: Dirk Mueller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]