This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR6321

From: Dirk Mueller <dmuell at gmx dot net>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 30 Oct 2006 20:45:44 +0100
Subject: Re: [PATCH] PR6321
References: <200610290153.30738.dmuell@gmx.net> <45457016.7030405@codesourcery.com>

On Monday, 30. October 2006 04:23, Mark Mitchell wrote:

> The idea of this patch is fine, but the function name main_args_warning
> isn't very good.  Please use "check_type_of_main" instead.

$ grep " check_" c-common.h   | wc -l
4
$ grep "_warning" c-common.h   | wc -l
6

I don't want to argue, but the function doesn't actually check the (return) 
type of the function. How about "check_main_arguments" 
or "check_main_function_arguments" ?

Dirk

Follow-Ups:
- Re: [PATCH] PR6321
  - From: Mark Mitchell

References:
- [PATCH] PR6321
  - From: Dirk Mueller
- Re: [PATCH] PR6321
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]