This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR29216 & PR29394 - (Redux) Default initialization for derived types that become defined.


Erik,

Thanks!

Missing '('. And perhaps "Set new argument for gfc_trans_assignment to
false" would be clearer? Or something; right now that sentence look
a little bit too brief to my eyes. But I'm not a native speaker, so
don't trust me on things like this.


Yes for the '(' .

On the briefness - I have been taken to task three times for being too verbose in ChangeLog entries, so I have been trying to make terseness an art form. I'll do as you say, since it is closer to my preference



* trans-stmt.c (gfc_trans_forall_1): The same.
* trans-stmt.h : Add prototype for gfc_trans_init_assign.
* trans.c (gfc_trans_code): Implement EXEC_INIT_ASSIGN.
* trans.h : Add new boolean argument to the prototype of
gfc_trans_assignment.
* resolve.c (resolve_allocate_exp): Replace EXEC_ASSIGN by
EXEC_INIT_ASSIGN.
(resolve_code): EXEC_INIT_ASSIGN does not need resolution.
(apply_default_init): New function.
(resolve_symbol): Call it for derived types that become
defined but which do not already have an initialization
expression..
* st.c (gfc_free_statement): Include EXEC_INIT_ASSIGN.


I don't see the changes to trans-expr.c mentioned anywhere.



Duuuhh!

It'll be in place tomorrow am.

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]