This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] mips: Allow larger values for __aligned__
- From: Carlos O'Donell <carlos at codesourcery dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Ian Lance Taylor <iant at google dot com>, Richard Sandiford <richard at codesourcery dot com>, echristo at apple dot com
- Date: Fri, 13 Oct 2006 15:29:54 -0400
- Subject: Re: [PATCH] mips: Allow larger values for __aligned__
- References: <20060920224707.GI9301@lios> <m3u03193jb.fsf@localhost.localdomain> <20061004155020.GH29333@lios> <200610131925.32461.ebotcazou@adacore.com>
On Fri, Oct 13, 2006 at 07:25:32PM +0200, Eric Botcazou wrote:
> > Tested without regression on i686-pc-linux-gnu.
>
> Am I the only one to see this?
You are compiling with -Werror, is that normal? I don't compile with
-Werror for testing.
> /home/eric/gnat/gnat6/native32/./prev-gcc/xgcc
> -B/home/eric/gnat/gnat6/native32/./prev-gcc/
> -B/home/eric/install/gnat6/i586-suse-linux/bin/ -c -O2 -g
> -fomit-frame-pointer -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes
> -Wmissing-prototypes -pedantic -Wno-long-long -Wno-variadic-macros
> -Wno-overlength-strings-Wold-style-definition -Wmissing-format-attribute
> -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/eric/gnat/gnat6/src/gcc
> -I/home/eric/gnat/gnat6/src/gcc/. -I/home/eric/gnat/gnat6/src/gcc/../include
> -I/home/eric/gnat/gnat6/src/gcc/../libcpp/include
> -I/home/eric/gnat/gnat6/src/gcc/../libdecnumber
> -I../libdecnumber /home/eric/gnat/gnat6/src/gcc/tree-vectorizer.c -o
> tree-vectorizer.o
> cc1: warnings being treated as errors
> /home/eric/gnat/gnat6/src/gcc/tree-vectorizer.c: In function
> 'vect_can_force_dr_alignment_p':
> /home/eric/gnat/gnat6/src/gcc/tree-vectorizer.c:1532: warning: comparison is
> always true due to limited range of data type
> make[3]: *** [tree-vectorizer.o] Error 1
> make[3]: Leaving directory `/home/eric/gnat/gnat6/native32/gcc'
> make[2]: *** [all-stage2-gcc] Error 2
> make[2]: Leaving directory `/home/eric/gnat/gnat6/native32'
> make[1]: *** [stage2-bubble] Error 2
> make[1]: Leaving directory `/home/eric/gnat/gnat6/native32'
> make: *** [all] Error 2
>
> bool
> vect_can_force_dr_alignment_p (tree decl, unsigned int alignment)
> {
> if (TREE_CODE (decl) != VAR_DECL)
> return false;
>
> if (DECL_EXTERNAL (decl))
> return false;
>
> if (TREE_ASM_WRITTEN (decl))
> return false;
>
> if (TREE_STATIC (decl))
> return (alignment <= MAX_OFILE_ALIGNMENT);
>
>
> Moreover, why did you remove the guard for the macro?
The elfos.h header should always be included first. If there are cases
were it isn't please point those out to me and I will help.
Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716