This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, take 2] Fix PR target/28946
- From: Rask Ingemann Lambertsen <rask at sygehus dot dk>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "H. J. Lu" <hjl at lucon dot org>
- Date: Sat, 7 Oct 2006 10:23:19 +0200
- Subject: Re: [PATCH, take 2] Fix PR target/28946
- References: <44FDD0D0.90404@gmail.com> <Pine.LNX.4.44.0609070959210.2154-100000@www.eyesopen.com>
On Thu, Sep 07, 2006 at 10:08:32AM -0600, Roger Sayle wrote:
>
> It's now been a few days and RTH hasn't voiced an objection. Although
> the patch is ugly, I think this is just a consequence of the way GCC's
> combiner and RTL instruction selection work, and similar idioms are
> commonly used on other platforms.
Note that you could likely use code macros, code attributes, mode macros
and mode attributes to reduce the number of patterns in the MD file. I think
the i386 shift/rotate instructions are sufficiently uniform that you can do
so, even with the "add reg,reg" vs. "sal reg,reg" issue.
--
Rask Ingemann Lambertsen