This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix __builtin_frame_address on SPARC 64-bit


Eric Botcazou <ebotcazou@libertysurf.fr> writes:

> 2006-10-01  Eric Botcazou  <ebotcazou@libertysurf.fr>
> 
> 	* builtins.c (expand_builtin_return_addr): Deal with FRAME_ADDR_RTX.
> 	* config/sparc/sparc.h (FRAME_ADDR_RTX): Define.
> 	* doc/tm.texi (Basic Stack Layout): Document FRAME_ADDR_RTX.

OK, but:

> +@defmac FRAME_ADDR_RTX (@var{frameaddr})
> +A C expression whose value is RTL representing the value of the frame
> +address for the current frame.  @var{frameaddr} is the frame pointer
> +of the current frame.
> +@end defmac

Please expand this a little, e.g.:

    A C expression whose value is RTL representing the value of the frame
    address for the current frame.  This is used for the builtin function
    __builtin_frame_address.  frameaddr is the frame pointer of the
    current frame.  You need only define this macro if the frame address
    is not the same as the frame pointer.  Most machines do not need to
    define this macro.

OK with a change along those lines.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]