This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: add tests for pthread initialization macros

 > * gcc.dg/pthread-init-1.c: Define _GNU_SOURCE.
 > * gdd.dg/pthread-init-2.c: Likewise.
 > * gcc-dg/pthread-init-common.h: Add tests for
 > PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
 > PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP,
 > PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP and
 > PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP mutex initializers.
 > Uros.

Thanks for the patch.  My only suggestion would be that _GNU_SOURCE
should be defined once in pthread-init-common.h rather than repeated
in every .c file.  (There may be even more .c files someday so let's
avoid the duplication now.)

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]