Re: [PATCH] Repair __builtin_setjmp/__builtin_longjmp

[Eric Botcazou <ebotcazou at adacore dot com>]

> I apologize for disappearing for a while here; I've been traveling, and
> am digging out of the email pile now.

Either your traveling has affected a little your memory :-) or you hold 
yourself to an unrealistic standard; a few days is barely a while.

> Since <setjmp.h> is sometimes included in this file, you should do
> "#undef setjmp" before (re)defining setjmp.  Please make that change.

Done.

> With that change, the patch is OK.

Thanks.

> As to the issue of documenting built-ins, let's leave it aside for now;
> you're not making things any worse than they were before.

OK.

> However, my position remains that we should either define the semantics
> for builtins or explicitly prohibit their use.  I would also accept
> Kenner's suggestion that we prohibit their use, but then provide a
> "-fexpose-internal-builtins" option to allow their use in test-cases.
> But, as Paul Brook and others said, I think that silently allowing the
> use of magic builtins whose semantics we don't intend to guarantee over
> time is a bad idea.

I'll work on a patch for 4.3 to that effect.

-- 
Eric Botcazou