This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: add tests for pthread initialization macros
- From: "Kaveh R. Ghazi" <ghazi at caipclassic dot rutgers dot edu>
- To: ubizjak at gmail dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 27 Sep 2006 21:10:51 -0400 (EDT)
- Subject: Re: [PATCH]: add tests for pthread initialization macros
- References: <451AD9A7.9020709@gmail.com>
> Kaveh R. Ghazi wrote:
>
> > solaris. Also some other platforms, namely aix and alpha-osf have
> > their own problems and may benefit from this oversight as
> > well. I've added tests for "-W -Wall" and "-W -Wall -ansi" which
> > were separate
>
> Could these compile flags be changed to "-Wall -Wextra [-ansi]" as
> recommended by gcc documentation?
Sure I'll update my patch accordingly.
> > problems on solaris. We can add more if the other platforms have
> > their own issues. Also, we can easily add more macros if they
> > exist.
>
> Fedora Core 4 on x86_64 has issues with PTHREAD_MUTEX_INITIALIZER
> defined as "{ {0, } }" - please look at
> http://gcc.gnu.org/ml/gcc/2006-09/msg00525.html ...
> Uros.
Yes, that needs fixing too. I think someone who has access to such a
platform and can test it should write the fix. I.e. not me. :-) Part
of my motivation for installing the testcase is to bring to the
forefront other platforms where this kind of fix is necessary.
But I'm willing to help answer questions if you want to give it a try.
You can start by cut&pasting the existing fixes for the same macro and
changing it as needed for your glibc.
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu