This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Repair __builtin_setjmp/__builtin_longjmp
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 24 Sep 2006 13:30:04 -0400
- Subject: Re: [PATCH] Repair __builtin_setjmp/__builtin_longjmp
- References: <200609212245.31767.ebotcazou@adacore.com>
Eric Botcazou wrote:
The __builtin_setjmp/__builtin_longjmp support has been broken since Tree-SSA
was merged, see for example http://gcc.gnu.org/ml/gcc/2006-06/msg00577.html.
Now, as mentioned in the head comment of __builtin_setjmp, the Ada compiler
does rely on it for proper operation, namely error recovery.
I think the approach you've taken is fundamentally sound.
Have you done anything to prevent the new builtin_setjmp_* from being
called directly by users? If not, I think you should. If we really
want user code to be able to use these, we need to document them in the
user manual.
This patch is OK for mainline, once that issue is resolved, and assuming
no objections within 72 hours.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713