This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR24367 S/390 pic address handling
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: krebbel1 at de dot ibm dot com (Andreas Krebbel)
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 30 Aug 2006 18:23:09 +0200 (CEST)
- Subject: Re: [PATCH] PR24367 S/390 pic address handling
Andreas Krebbel wrote:
> ! if (TARGET_64BIT
> ! && (SYMBOLIC_CONST (operands[1])
> ! || (GET_CODE (operands[1]) == PLUS
> ! && REG_P (XEXP (operands[1], 0))
> ! && XEXP (operands[1], 0) == pic_offset_table_rtx
> ! && SYMBOLIC_CONST (XEXP (operands[1], 1)))))
The REG_P test is redundant with with == pic_offset_table_rtx
check.
Otherwise, this patch is fine. Thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
Linux on zSeries Development
Ulrich.Weigand@de.ibm.com