This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR C++/28349, ICE with va_args and references
- From: Geoffrey Keating <geoffk at apple dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 29 Aug 2006 15:15:42 -0700
- Subject: Re: [PATCH] Fix PR C++/28349, ICE with va_args and references
- References: <1156822437.18261.11.camel@celery.andrew.com>
Andrew Pinski <pinskia@physics.uc.edu> writes:
> The problem here is that we don't try to undo the reference after
> building *(__builtin_trap (), (int&*)0). Really there is no reason we
> should have a pointer to a reference here so just creating a pointer to
> the type that the old type references fixes the problem without causing
> an ICE.
>
> OK? Bootstrapped and tested on i686-pc-linux-gnu with no regressions.
OK.
> :ADDPATCH C++:
:REVIEWMAIL:
> cp/ChangeLog:
> * call.c (build_x_va_arg): Remove the reference type
> from the type before creating the pointer type.
>
> testsuite/ChangeLog:
> * testsuite/g++.dg/warn/var-args1.C: New test.