This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PING: [C PATCH] Various c_do_switch_warnings improvements

From: Mark Mitchell <mark at codesourcery dot com>
To: Roger Sayle <roger at eyesopen dot com>
Cc: gcc-patches at gcc dot gnu dot org, Joseph Myers <joseph at codesourcery dot com>
Date: Fri, 25 Aug 2006 09:01:26 -0700
Subject: Re: PING: [C PATCH] Various c_do_switch_warnings improvements
References: <Pine.LNX.4.44.0608240459530.1311-100000@www.eyesopen.com>

Roger Sayle wrote:

2006-07-08 Roger Sayle <roger@eyesopen.com>

	* tree.h (CASE_LOW_SEEN, CASE_HIGH_SEEN): New macros for manipulating
	temporary visit flags on CASE_LABEL_EXPRs.
	* c-common.c (match_case_to_enum): Add function comment.  Avoid
	O(N) loop, by looking up both CASE_LOW_SEEN and CASE_HIGH_SEEN.
	(c_do_switch_warnings):  Reorganize to record CASE_LOW_SEEN and
	CASE_HIGH_SEEN for enumerated types.  If the switch expression is
	a constant, only warn if that constant value isn't handled.

	* gcc.dg/Wswitch-enum-2.c: New test case.
	* gcc.dg/Wswitch-enum-3.c: Likewise.

OK, unless a C front-end maintainer objects within 24 hours.

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

References:
- PING: [C PATCH] Various c_do_switch_warnings improvements
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]