This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fixes to ipa branch
- From: Razya Ladelsky <RAZYA at il dot ibm dot com>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, hubicka at ucw dot cz, jh at suse dot cz
- Date: Thu, 24 Aug 2006 11:43:33 +0300
- Subject: Re: Fixes to ipa branch
Jan Hubicka <jh@suse.cz> wrote on 24/08/2006 00:48:07:
> > Hi,
> >
> > This patch includes several fixes to ipa branch.
> > The targhooks and rs6000 fixes are necessary for compilation on
powerpc
> > and
> > also for testing the powerpc suite.
>
> What are precisely those changes shooting for? Is it something that can
> be brought in by another merge? (I am leaving for two weeks of vacation
> at friday, so I will unlikely to be able to do it before that, but they
> looks like something that is quite independent on IPA branch).
> >
I think so, yes.
These are parts that I took from mainline.
We had troubles bootstraping the branch on powerpc without them.
> > The rest of the changes refer to the dominance info (they were
suggested
> > by Daniel Berlin a while ago)
>
> My approach to dominance info so far has been to always calculate just
> one (ie not have it privatized). I am not oposed to privatizing it at
> all (just we probably should be sure to not leave it hanging around all
> CFGs for no good reason), but I wonder what do you need it for?
>
Well, when I ran some tests (for instance art benchmark) with matrix
flattening enabled,
I got segmentation fault during verify_flow that referred to dominance
information.
Perhaps there is another way to handle it.
Paulo wrote that he had another way of working around it:
"I was working around
this by calling free_dominance_info before every pop_cfun."
Your thoughts?
> Honza
> >
> >
> > 2006-08-23 Razya Ladelsky <razya@il.ibm.com>
> >
> > * targhooks.c (default_internal_arg_pointer): New function.
> > * dominance.c (dom_computed, n_bbs_in_dom_tree): Remove
> > definitions.
> > * fortran/decl.c (gfc_match_entry):Add missing declaration.
> > * function.h (dom_state): Add enumerator.
> > (dom_computed, n_bbs_in_dom_tree): Add new fields to function
> > struct,
> > add matching macros.
> > * basic-block.h (dom_state, dom_computed): Remove.
> > * config/rs6000/rs6000.c: Merge (partially) from mainline.
> >
> >
>
>