This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH for debug/23336 - enums types missing from debug info
Daniel Jacobowitz wrote:
> On Mon, Jul 24, 2006 at 10:09:23AM -0700, Mark Mitchell wrote:
>>> * dwarf2out.c (dwarf2out_abstract_function): Save and restore
>>> cfun also.
>> Why is this necessary? (It doesn't seem bad to me; just curious.)
>>
>> The C++ changes are fine. I'll let a C maintainer review the C bits.
>> Once you answer the question above, I'll re-review the DWARF bits.
>
> There's already code to walk used_types_hash for the current function,
> whether we're outputing a real function or an abstract copy. But it
> looks at cfun to find it. It seemed reasonable to fix a place where
> cfun and current_function_decl were out of sync as a solution.
OK.
> If the C++ bits are OK, I think the C bit is obvious; but I'll ask
> Joseph to take a look.
I'll approve the C bits, conditional on no objections from a C
maintainer within 24 hours.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713