This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR c++/27668

Lee Millward wrote:

> 2006-07-24  Lee Millward  <lee.millward@codesourcery.com>
> 
>        PR c++27668
>        * pt.c (process_template_parm): Store invalid template
>        parameters in the parameter list as error_mark_nodes.
>        (push_inline_template_parms_recursive): Handle invalid
>        template parameters indicated by error_mark_node.
>        (check_default_tmpl_args): Likewise.
>        (coerce_template_parms): Likewise.
>        (mangle_class_name_for_template): Likewise.
>        * error.c (dump_template_argument_list): Likewise.

I think this is The Right Thing -- but it may cause more
ICE-after-valid-error problems, as we find other parts of the compiler
not accustomed to seeing an error_mark_node here.  However, in all those
cases, we will have already issued an error message, so I'm not
particularly worried about that.

Therefore, this is OK for mainline and 4.1.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]