Re: [patch, update] PR25289 Large file IO

[Janne Blomqvist <Janne dot Blomqvist at tkk dot fi>]

:REVIEWMAIL:

Jerry DeLisle wrote:
> This patch defines a new type GFC_LARGE_IO_INT and uses that to define 
> rec in st_parameter_dt.  off_t is preserved as is for the definition of 
> gfc_offset.

I understood FX comment to mean that gfc_offset is sort of redundant 
since it's always off_t anyway, i.e. one could do a search-and-replace 
in libgfortran replacing all occurences of gfc_offset with off_t. But 
that's certainly the topic of another patch (if it even was what FX 
meant in the first place?).

> OK for trunk?

Yes, with a small typo fix decribed below.

> ===================================================================
> *** gcc/fortran/trans-types.c	(revision 115683)
> --- gcc/fortran/trans-types.c	(working copy)

> *************** gfc_init_kinds (void)
> *** 140,145 ****
> --- 144,157 ----
>         i_index += 1;
>       }
>   
> +   /* Set the kind used to match gfc_offset in libgfortran.  This is used for
                                    1

You should have GFC_LARGE_IO_INT here.

--
Janne