This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: line insn notes cleanups (haifa-sched and modulo-sched)


Daniel Berlin wrote:

Vladimir Makarov wrote:


Tehila Meyzels wrote:



Thanks for the comments.
Following is the fixed svn diff output.

I'm going to build and test it also on x86 (i686-pc-linux-gnu), when I'll
be able to.
Currently, I built and checked it only on ppc (powerpc-suse-linux).






Sorry, I don't understant why do you need this patch.

You will not have additional failures on gcc regression tests. But you will see a big difference in gdb. Line notes are important for debugging. They should be bound to the corresponding insns.


You could also get away with just attaching the info directly to the
insn, instead of notes. Then you wouldn't have to deal with moving them
around at all :)


Riding off the line notes is a good idea and I really like it but they have not removed yet. As I wrote Tehila, scheduler should be the last place to remove the code dealing with the line notes because without the code the line notes will misinform and confuse people at least when they look at dump files after the insn scheduler work.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]