This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [dataflow] PATCH removal of more of flow.c.
- From: Richard Sandiford <richard at codesourcery dot com>
- To: Kenneth Zadeck <zadeck at naturalbridge dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "Berlin, Daniel" <dberlin at dberlin dot org>, Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Date: Thu, 20 Jul 2006 11:06:37 +0100
- Subject: Re: [dataflow] PATCH removal of more of flow.c.
- References: <44BC15C9.2050204@naturalbridge.com>
Kenneth Zadeck <zadeck@naturalbridge.com> writes:
> + /* Do not make the log link for frame pointer. */
> + if ((regno == FRAME_POINTER_REGNUM
> + && (! reload_completed || frame_pointer_needed))
> +#if FRAME_POINTER_REGNUM != HARD_FRAME_POINTER_REGNUM
> + || (regno == HARD_FRAME_POINTER_REGNUM
> + && (! reload_completed || frame_pointer_needed))
> +#endif
> +#if FRAME_POINTER_REGNUM != ARG_POINTER_REGNUM
> + || (regno == ARG_POINTER_REGNUM && fixed_regs[regno])
> +#endif
> + )
> + continue;
Minor niggle, sorry, but the comment doesn't really say what the code
is doing. How about something like "Do not make log links for function-
invariant hard registers."? I hope it's a bit more accurate, and it
makes it more obvious why we don't create the links.
Richard