This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.

From: Kazu Hirata <kazu at codesourcery dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
Date: Mon, 17 Jul 2006 00:35:18 -0400
Subject: Re: [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.
References: <200607170408.k6H48Zxd017878@sparrowhawk.codesourcery.com> <m38xmsq2ed.fsf@localhost.localdomain>

Hi Ian,

+tree *
+nth_parm_type_p (tree parmtypes, int n)

By gcc convention a function which ends with "_p" is a predicate, not
a function which returns a pointer.  Please use a different name.

A very good point, but then I am having trouble coming up with a good name. How about nth_parm_typep (without '_')? I got a hint from call_expr_argp.

Kazu Hirata

Follow-Ups:
- Re: [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.
  - From: Ian Lance Taylor

References:
- [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.
  - From: Kazu Hirata
- Re: [lto] Add nth_parm_type_p, alloc_parm_types, vec_heap2parm_types.
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]