This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fix proto building
- From: Ian Lance Taylor <iant at google dot com>
- To: Mike Stump <mrs at apple dot com>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: 12 Jul 2006 18:23:38 -0700
- Subject: Re: fix proto building
- References: <A1E63C41-CCCF-491A-9FA3-8CD4205D314E@apple.com>
Mike Stump <mrs@apple.com> writes:
> This fixes a warning about clean_text_p being clobbered by setjmp.
>
> Checking in as obvious as no maintainer has objected to it after 6
> months of having considered it. Personally, I'd rather have the SC
> appoint a maintainer that is able to review this type of patch, or
> change the rules to allow it to be checked in without a review by the
> appointed maintainers. :-(
Personally, I think this was a righteous checkin.
The problem, of course, is that the proto files are in a hole where
the only people who can approve changes are the people with blanket
write privileges. And none of them are especially active at the
moment outside of the C++ frontend.
So, one incremental improvement is to give blanket write privileges to
more people. Another is to assign a maintainer for the proto files,
orput them under, e.g., "build machinery." Another is to just get rid
of the darn things--that one gets my vote.
Ian