This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][RFC] Remove volatile from data members in libstdc++

From: Paolo Carlini <pcarlini at suse dot de>
To: Richard Guenther <rguenther at suse dot de>
Cc: "Boehm, Hans" <hans dot boehm at hp dot com>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Wed, 12 Jul 2006 14:10:37 +0200
Subject: Re: [PATCH][RFC] Remove volatile from data members in libstdc++
References: <65953E8166311641A685BDF71D865826C1DD06@cacexc12.americas.cpqcorp.net> <Pine.LNX.4.64.0607121152540.5439@nyjnma.fhfr.qr> <Pine.LNX.4.64.0607121223420.5439@nyjnma.fhfr.qr>

Hi Richard,

Needs the typo fix below. I wonder if this is an ABI change?

I'm afraid it is, because you are changing the struct _Refcount_Base, at least its size. Not to mention interoperability between one object using mutexes and another using atomic operations...

Tested on x86_64-unknown-linux-gnu.

Ok for mainline?

Please wait a few hours in case Hans has something to add, then commit to v7-branch.

Thanks a lot!
Paolo.

P.S. When MT is involved, usually I regtest on a multi-way machine, like one among the 4-way ia64 and x86-64 machines of our internal network...

Follow-Ups:
- Re: [PATCH][RFC] Remove volatile from data members in libstdc++
  - From: Richard Guenther

References:
- RE: [PATCH][RFC] Remove volatile from data members in libstdc++
  - From: Boehm, Hans
- RE: [PATCH][RFC] Remove volatile from data members in libstdc++
  - From: Richard Guenther
- RE: [PATCH][RFC] Remove volatile from data members in libstdc++
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]