This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto] Add a parameter to dump_parameters.


Hi Mark,

2006-07-10 Kazu Hirata <kazu@codesourcery.com>

	* error.c (dump_type, dump_type_suffix, dump_function_decl):
	Adjust calls to dump_parameters.
	(dump_parameters): Add a parameter to specify how many
	parameters are to be skipped.


OK.

Thanks for a review.


At some point, it would be nice to have a varargs_parmtypes_p
function which did something like:

  num_parm_types (parmtypes) != 0
  && nth_parm_type (num_parm_types (parmtypes) - 1) != void_type_node

since that seems to come up a lot.  However, that's *another* cleanup,
and you're already on a big one, so I wouldn't suggest you do this,
unless you think it'll make it easier to do the existing cleanup.

I've got that covered. See stdarg_p in gcc/tree.c. :-)


Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]