This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Java PATCH] Fix libjava bootstrap issues on HP-UX 11.00
- From: Tom Tromey <tromey at redhat dot com>
- To: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: roger at eyesopen dot com (Roger Sayle), gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: 05 Jul 2006 11:42:15 -0600
- Subject: Re: [Java PATCH] Fix libjava bootstrap issues on HP-UX 11.00
- References: <200606290146.k5T1kmWk010640@hiauly1.hia.nrc.ca>
- Reply-to: tromey at redhat dot com
>>>>> "Dave" == John David Anglin <dave@hiauly1.hia.nrc.ca> writes:
>> 2006-06-28 Roger Sayle <roger@eyesopen.com>
>> * include/posix.h: Ensure that _REENTRANT is defined on HP-UX.
>> * java/io/natFilePosix.cc: #include <platform.h>.
Dave> I'm not convinced this is the correct approach to fix the lack
Dave> of _REENTRANT being defined (see below). This might also allow
Dave> building libjava on hpux 10.x. There are some testsuite issues
Dave> which I haven't had a chance to look at in detail.
I never remember whether _REENTRANT is defined on all the
posix-threads-using platforms. That's why I've been (half-heartedly)
pushing for a solution which is transparently HPUX-only... it is just
simpler to review :-)
If _REENTRANT is defined everywhere, then a patch like this one
is fine by me. Otherwise I think it need to be handled some other
way, e.g., by changing the configure checks to realize that the
functions in question are not actually available.
Tom