This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fortran/28213 -- Fix Hollerith in IO list
- From: Feng Wang <wf_cs at yahoo dot com>
- To: Jerry DeLisle <jvdelisle at verizon dot net>, Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 4 Jul 2006 22:26:55 +0800 (CST)
- Subject: Re: [PATCH] fortran/28213 -- Fix Hollerith in IO list
--- Jerry DeLisle <jvdelisle@verizon.net>写道:
> Steve Kargl wrote:
> > The following patch fixes an ICE when a Hollerith constant
> > appears in an IO list. For some reason, the attached test
> > is not caught by DejaGNU. I ping Janis for advice on the
> > test. I would like to commit the patch even without a test,
> > and then commit the test once Janis and I have exchanged
> > some thoughts.
> >
>
> If you will accept my review on this, its simple enough and looks OK to
> commit.
>
Yes, it's simple. But the way is wrong. Hollerith constant should be accepted
to print. Just try this enclosed patch.
Best Regards,
Feng Wang
--
Creative Compiler Research Group,
National University of Defense Technology, China.
___________________________________________________________
抢注雅虎免费邮箱-3.5G容量，20M附件！
http://cn.mail.yahoo.com
Index: trans-io.c
===================================================================
--- trans-io.c £¨ÐÞ¶©°æ 115169£©
+++ trans-io.c £¨¹¤×÷¿½±´£©
@@ -1700,6 +1700,7 @@ transfer_expr (gfc_se * se, gfc_typespec
break;
case BT_CHARACTER:
+ case BT_HOLLERITH:
if (se->string_length)
arg2 = se->string_length;
else