This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Correct some whitespace/newline style issues


Roger Sayle wrote:
> Whilst investigating the regression PR26983, I recently needed to find
> the declaration of the function finalize_block_changes.  Confusingly,
> it's wasn't picked up by my first attempt using grep ^finalize_block.
> Turns out this is one of a rare handful of funtion definitions that
> don't adhere to the GNU/GCC coding style, where the function name's
> identifier should appear as the very first thing on a new line.
> 
> The following whitespace-only clean-up patch addresses this and similar
> examples in the gcc/ directory that I could easily identify with a
> grep "^void [^*]".  I honestly can't remember why I was motivated
> (annoyed) enough to tidy this up during stage 3.
> 
> The following patch has been tested on i686-pc-linux-gnu with a full
> "make bootstrap", all default languages including Ada, and regression
> tested with a top-level "make -k check" with no new failures.
> 
> Ok for mainline?
> *************** struct tree_opt_pass pass_ipa_pta =
> *** 4685,4691 ****
>   };
> 
>   /* Initialize the heapvar for statement mapping.  */
> ! void
>   init_alias_heapvars (void)
>   {
>     heapvar_for_stmt = htab_create_ggc (11, tree_map_hash, tree_map_eq, NULL);
> --- 4686,4692 ----
>   };
> 
>   /* Initialize the heapvar for statement mapping.  */
> ! void
>   init_alias_heapvars (void)
>   {
>     heapvar_for_stmt = htab_create_ggc (11, tree_map_hash, tree_map_eq, NULL);

So what is different here?
Is there trailing whitespace or something?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]