This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR28174 - actual args with substring refs and PR28167 - character array constructors
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Paul Thomas <paulthomas2 at wanadoo dot fr>
- Cc: patch <gcc-patches at gcc dot gnu dot org>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, Harald Anlauf <anlauf at gmx dot de>
- Date: Mon, 3 Jul 2006 11:33:19 -0700
- Subject: Re: [Patch, fortran] PR28174 - actual args with substring refs and PR28167 - character array constructors
- References: <44A44E1E.7030101@wanadoo.fr>
On Fri, Jun 30, 2006 at 12:03:10AM +0200, Paul Thomas wrote:
>
> PR fortran/28167
> * array.c (resolve_character_array_constructor): Remove static
> attribute, make use of element charlens for the expression and
> pick up constant string lengths for expressions that are not
> themselves constant.
Paul, the patch is ok with the possible exception of the above.
If you removed "static" to make the function visible to a function
in another file, then I believe our convention is start the
function with the "gfc_" prefix. Hence, resolve_character_array_constructor
becomes gfc_resolve_character_array_constructor.
--
Steve