This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [LTO] PATCH: builtins.c/CALL_EXPR patch, take 2


Roger Sayle wrote:

I'll leave it to the LTO branch maintainers to comment further, but
I will mention that there are a large number of style issues with
this patch (function comments that don't describe arguments, incorrect
indentation, incorrect punctuation in comments, unnecessary parenthesis
in conditionals and so on).

Hmmm. Many (most?) of the function comments originally in this file didn't describe the arguments, and I tried to leave them alone as much as possible to avoid introducing extraneous crud into the patch. I tried to format and indent the code according to the GNU coding standards document, which doesn't say anything about minimizing parentheses in conditionals, but does suggest inserting extra ones elsewhere. If I'm doing something specifically wrong, I'd appreciate it if somebody could point it out to me so I can fix it.


-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]