This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re:PATCH: PR c/26993: fix weakref ICE on malformed input

From: Geoff Keating <geoffk at geoffk dot org>
To: Alexandre Oliva <aoliva at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 29 Jun 2006 15:57:44 -0400
Subject: Re:PATCH: PR c/26993: fix weakref ICE on malformed input

Hi Alexandre,

	PR c/26993
	* c-common.c (handle_weakref_attribute): Ignore attribute in
	the same conditions the alias attribute is ignored.

This patch is OK, except that this comment:

+  /* We must ignore the attribute when it is associated with
+     local-scoped decls, since attribute alias is ignored and, more
+     importantly, such symbols do not have a DECL_WEAK field.  */

is confusing, because some such symbols will be VAR_DECLs or FUNCTION_DECLs and they do have a DECL_WEAK field, it just isn't meaningful.

:REVIEWMAIL:

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]