This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR c++/28112: ICE with invalid argument in attribute


Volker Reichelt wrote:

> The patch below doesn't add the attribute to the attribute_list if the
> arguments are invalid. The patch looks much longer because of indentation
> changes. It also removes a superflous pair of parentheses around the
> call to cp_parser_parenthesized_expression_list and corrects a comment.

This patch is OK.  (By the way, the reason for the extra parentheses is
that otherwise Emacs does not auto-format the code correctly.  It's OK
to take them out, but I may put them back in next time I edit that code
-- hopefully never!)

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]