This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran,patch] Get rid of some convert calls in favor of build_int_cst
- From: "François-Xavier Coudert" <fxcoudert at gmail dot com>
- To: "Steve Kargl" <sgk at troutmask dot apl dot washington dot edu>
- Cc: gfortran <fortran at gcc dot gnu dot org>, patch <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 20 Jun 2006 09:49:12 +0200
- Subject: Re: [gfortran,patch] Get rid of some convert calls in favor of build_int_cst
- References: <4496F308.4060305@gmail.com> <20060619235349.GA13279@troutmask.apl.washington.edu>
2006-06-19 Francois-Xavier Coudert <coudert@clipper.ens.fr>
* trans-expr.c (gfc_conv_missing_dummy, gfc_conv_unary_op,
gfc_conv_cst_int_power, gfc_conv_string_tmp,
gfc_conv_function_call): Replace calls to convert on constant
integer nodes by build_int_cst.
* trans-stmt.c (gfc_trans_do): Likewise.
* trans-io.c (set_internal_unit, transfer_namelist_element):
Likewise.
* trans-decl.c (build_entry_thunks): Likewise.
This looks to be a straight forward mechanic change.
It is OK for trunk.
Thanks.
Please, let it sit in trunk for
at least a week before considering the patching of 4.1.
I'll note that I'm leary of non-bug changes going into
4.1.
I understand, but it really is a pain to have to rewrite bug-fixing
patches just because of mechanic changes between branches.
Also, does this change allow the remove of any of the
integer_zero_node, etc. nodes?
Hum, they're common to all front-ends (not gfc_ prefix), and widely
used outside the fortran directory also. So, I don't think we should
remove them right now, at least give other people a prior notice! :)
FX