This is the mail archive of the
mailing list for the GCC project.
Re: [Patch, fortran] PR16206 - array initializers
My last comment. In the following section of code, do reallyYes, I do mean to fall through; that way, further references are processed.
mean to fallthrough to AR_FULL in the switch? If yes, then
the convention is to add a comment as I've shown below.
AFAICT, the patch is OK (with the fallthrough comment).
+ case AR_SECTION:Will do, although I have always thought it to be a bit redundant.
+ if (find_array_section (p, p->ref) == FAILURE)
+ return FAILURE;
+ p->ref->u.ar.type = AR_FULL;
+ /* FALLTHROUGH. */
! if (p->ref->next != NULL
! && (p->ts.type == BT_CHARACTER || p->ts.type == BT_DERIVED))
! cons = p->value.constructor;
! for (; cons; cons = cons->next)
! cons->expr->ref = copy_ref (p->ref->next);
! simplify_const_ref (cons->expr);
! gfc_free_ref_list (p->ref);
! p->ref = NULL;